Skip to content

Conversation

kof
Copy link
Member

@kof kof commented Mar 27, 2025

#4203

Description

Original PR #4914

Questions: Should we keep both overflow hidden and clip? or replace hidden with clip and keep hidden to advanced?

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof temporarily deployed to development March 27, 2025 10:19 — with GitHub Actions Inactive
@kof kof temporarily deployed to development March 27, 2025 10:19 — with GitHub Actions Inactive
@kof kof temporarily deployed to development March 27, 2025 10:19 — with GitHub Actions Inactive
@kof kof temporarily deployed to development March 27, 2025 10:19 — with GitHub Actions Inactive
@kof kof closed this Mar 27, 2025
@kof kof temporarily deployed to development March 27, 2025 10:58 — with GitHub Actions Inactive
@kof kof temporarily deployed to development March 27, 2025 10:58 — with GitHub Actions Inactive
@kof kof temporarily deployed to development March 27, 2025 10:58 — with GitHub Actions Inactive
@kof kof temporarily deployed to development March 27, 2025 10:58 — with GitHub Actions Inactive
@TrySound TrySound deleted the replace-overflow-hidden branch June 26, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants